Round TimeWithTimeZone when supportsParametricDateTime is false#14950
Round TimeWithTimeZone when supportsParametricDateTime is false#14950martint merged 3 commits intotrinodb:masterfrom
TimeWithTimeZone when supportsParametricDateTime is false#14950Conversation
There was a problem hiding this comment.
good catch. I didn't notice this myself when I shared the link. 👍
There was a problem hiding this comment.
Don't convert to String before comparing. Compare directly against instances created with SqlTimeWithTimeZone.newInstance
There was a problem hiding this comment.
I agree in case of all other tests except here we don't apply any transformation, so we have to compare against another representation.
There was a problem hiding this comment.
Ah, yes, I meant to put the comment in the methods below. For this one, rename the test to testToString, as that's what's being tested here.
Also, this test is unrelated to the fix in this commit, so move it to a separate commit.
There was a problem hiding this comment.
Don't static import this method. The name is too ambiguous.
There was a problem hiding this comment.
This test is unrelated to the fix in this commit. Move it to a separate commit.
There was a problem hiding this comment.
Ah, yes, I meant to put the comment in the methods below. For this one, rename the test to testToString, as that's what's being tested here.
Also, this test is unrelated to the fix in this commit, so move it to a separate commit.
mdesmet
force-pushed
the
bug/sqltime-not-rounded
branch
from
a369a2d to
f83ecc2
Compare
mdesmet
force-pushed
the
bug/sqltime-not-rounded
branch
from
f83ecc2 to
4e42bd4
Compare
There was a problem hiding this comment.
Sorry for that, removed!
mdesmet
force-pushed
the
bug/sqltime-not-rounded
branch
from
4e42bd4 to
6a28dfb
Compare
3 participants
Description
When
PARAMETRIC_DATETIMEis not set, all temporal types should be rounded up to precision 3. However TimeWithTimeZone is not rounded.Non-technical explanation
Release notes
( ) This is not user-visible or docs only and no release notes are required.
(x) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: