Skip to content

Fix broken TestSharedGlueMetastore.getExpectedHiveCreateSchema#14940

Merged
ebyhr merged 1 commit intomasterfrom
ebi/iceberg-fix-ci
Nov 8, 2022
Merged

Fix broken TestSharedGlueMetastore.getExpectedHiveCreateSchema#14940
ebyhr merged 1 commit intomasterfrom
ebi/iceberg-fix-ci

Conversation

@ebyhr
Copy link
Copy Markdown
Member

@ebyhr ebyhr commented Nov 7, 2022

Description

Relates to #14285 (comment)

Release notes

(x) This is not user-visible or docs only and no release notes are required.

Glue tests didn't run for 442e31c because the PR came from forked repository.
@ebyhr ebyhr added the no-release-notes This pull request does not require release notes entry label Nov 8, 2022
@ebyhr ebyhr merged commit cac8bfe into master Nov 8, 2022
@ebyhr ebyhr deleted the ebi/iceberg-fix-ci branch November 8, 2022 06:32
@github-actions github-actions bot added this to the 403 milestone Nov 8, 2022
@hashhar
Copy link
Copy Markdown
Member

hashhar commented Nov 8, 2022

Somehow there's still a failure - it seems it's in different module so tests didn't run for that: (https://github.com/trinodb/trino/actions/runs/3416971472/jobs/5688164447)

Error:  io.trino.plugin.deltalake.TestDeltaLakeSharedGlueMetastoreWithTableRedirections.testShowSchemas  Time elapsed: 0.07 s  <<< FAILURE!
java.lang.AssertionError: 
expected [CREATE SCHEMA hive_with_redirections.test_shared_schema_1j0y821y2c
AUTHORIZATION ROLE public
WITH (
   location = '/tmp/TrinoTest2689208705195123768/delta_lake_data'
)] but found [CREATE SCHEMA hive_with_redirections.test_shared_schema_1j0y821y2c
WITH (
   location = '/tmp/TrinoTest2689208705195123768/delta_lake_data'
)]
	at org.testng.Assert.fail(Assert.java:94)
	at org.testng.Assert.failNotEquals(Assert.java:513)
	at org.testng.Assert.assertEqualsImpl(Assert.java:135)
	at org.testng.Assert.assertEquals(Assert.java:116)
	at org.testng.Assert.assertEquals(Assert.java:190)
	at org.testng.Assert.assertEquals(Assert.java:200)
	at io.trino.plugin.deltalake.BaseDeltaLakeSharedMetastoreWithTableRedirectionsTest.testShowSchemas(BaseDeltaLakeSharedMetastoreWithTableRedirectionsTest.java:85)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:104)
	at org.testng.internal.Invoker.invokeMethod(Invoker.java:645)
	at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:851)
	at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1177)
	at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:129)
	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:112)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
	at java.base/java.lang.Thread.run(Thread.java:833)

@ebyhr
Copy link
Copy Markdown
Member Author

ebyhr commented Nov 8, 2022

Ugh, let me send another PR.

@ebyhr
Copy link
Copy Markdown
Member Author

ebyhr commented Nov 8, 2022

Sent #14946

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed no-release-notes This pull request does not require release notes entry

Development

Successfully merging this pull request may close these issues.

2 participants