Support result in LoggingInvocationHandler#14935
Merged
kokosing merged 1 commit intotrinodb:masterfrom Nov 9, 2022
Merged
Conversation
kokosing
approved these changes
Nov 7, 2022
lib/trino-plugin-toolkit/src/main/java/io/trino/plugin/base/util/LoggingInvocationHandler.java
Outdated
Show resolved
Hide resolved
Member
|
Is there any places where we leverage this? Maybe there are some interfaces that return simple objects like access controls. |
Member
|
FYI @findepi |
nevillelyh
force-pushed
the
neville/invocation-handler
branch
from
cc3721d to
23be30b
Compare
Member
Author
|
It's used by 3 classes only.
|
nevillelyh
force-pushed
the
neville/invocation-handler
branch
from
23be30b to
3c14288
Compare
kokosing
approved these changes
Nov 9, 2022
Member
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support method returned value in
LoggingInvocationHandler.Non-technical explanation
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: