Fix incorrect results when FTE and bulk INSERT is enabled in SQL Server #14926
Merged
ebyhr merged 2 commits intotrinodb:masterfrom Nov 7, 2022
Merged
Fix incorrect results when FTE and bulk INSERT is enabled in SQL Server #14926ebyhr merged 2 commits intotrinodb:masterfrom
ebyhr merged 2 commits intotrinodb:masterfrom
Conversation
This is helpful to debug the generated INSERT statement.
Member
Author
|
Looking CI failures. |
ebyhr
force-pushed
the
ebi/sqlserver-bulk-insert-null
branch
from
1e5c322 to
c5364e1
Compare
losipiuk
reviewed
Nov 7, 2022
Member
losipiuk
left a comment
losipiuk
left a comment
There was a problem hiding this comment.
LGTM. Does new test cover that?
Member
Author
|
Yes, the new assertion failed without this change. |
Column orders between INSERT statement and table definition must be same when using bulk insert in SQL Server.
ebyhr
force-pushed
the
ebi/sqlserver-bulk-insert-null
branch
from
c5364e1 to
f90f773
Compare
Member
Author
|
@losipiuk I pushed small change. Could you take another look? |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #14856
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: