Skip to content

Add @Flaky annotation to Databricks product tests#14899

Merged
ebyhr merged 2 commits intomasterfrom
ebi/delta-databricks-flaky
Nov 7, 2022
Merged

Add @Flaky annotation to Databricks product tests#14899
ebyhr merged 2 commits intomasterfrom
ebi/delta-databricks-flaky

Conversation

@ebyhr
Copy link
Copy Markdown
Member

@ebyhr ebyhr commented Nov 4, 2022

Description

Add @Flaky annotation to Databricks product tests
Relates to #14391

Release notes

(x) This is not user-visible or docs only and no release notes are required.

@ebyhr ebyhr added the no-release-notes This pull request does not require release notes entry label Nov 4, 2022
@cla-bot cla-bot bot added the cla-signed label Nov 4, 2022
@findinpath
Copy link
Copy Markdown
Contributor

I've found that the following tests are missing the annotation:

  • io.trino.tests.product.deltalake.TestDeltaLakeAlterTableCompatibility#testTrinoAlterTablePreservesTableMetadata
    (probably not needed because it performs only a CREATE TABLE statement on delta )
  • io.trino.tests.product.deltalake.TestDeltaLakeAlterTableCompatibility#testTrinoAlterTablePreservesTableMetadata
    (probably not needed because it performs only a CREATE TABLE statement on delta )
  • io.trino.tests.product.deltalake.TestDeltaLakeAlterTableCompatibility#testTrinoAlterTablePreservesGeneratedColumn
  • io.trino.tests.product.deltalake.TestDeltaLakeDatabricksCheckpointsCompatibility#testTrinoCheckpointNullStatisticsForRowType
  • io.trino.tests.product.deltalake.TestDeltaLakeDatabricksCheckpointsCompatibility#testDatabricksCheckpointNullStatisticsForRowType
  • io.trino.tests.product.deltalake.TestDeltaLakeDatabricksCheckpointsCompatibility#testTrinoWriteStatsAsJsonDisabled
    (probably not needed)
  • io.trino.tests.product.deltalake.TestDeltaLakeDatabricksCheckpointsCompatibility#testDatabricksWriteStatsAsJsonDisabled
    (probably not needed)
  • io.trino.tests.product.deltalake.TestDeltaLakeDatabricksCheckpointsCompatibility#testTrinoWriteStatsAsStructDisabled
    (probably not needed)
  • io.trino.tests.product.deltalake.TestDeltaLakeDatabricksCheckpointsCompatibility#testDatabricksWriteStatsAsStructDisabled
    (probably not needed)
  • io.trino.tests.product.deltalake.TestDeltaLakeDatabricksInsertCompatibility#testCheckConstraintsCompatibility
  • io.trino.tests.product.deltalake.TestDeltaLakeDatabricksInsertCompatibility#testCompression(java.lang.String)
    (probably not needed)
  • io.trino.tests.product.deltalake.TestDeltaLakeDatabricksInsertCompatibility#testWritesToTableWithCheckConstraintFails
  • io.trino.tests.product.deltalake.TestDeltaLakeDatabricksInsertCompatibility#testMetadataOperationsRetainCheckConstraints
  • io.trino.tests.product.deltalake.TestDeltaLakeDatabricksInsertCompatibility#testWritesToTableWithGeneratedColumnFails
  • io.trino.tests.product.deltalake.TestDeltaLakeDatabricksInsertCompatibility#testWritesToTableWithCDFFails
  • io.trino.tests.product.deltalake.TestHiveAndDeltaLakeRedirect#testInsertIntoDeltaTableFromHiveNonDefaultSchemaRedirect
  • io.trino.tests.product.deltalake.TestHiveAndDeltaLakeRedirect#testViewReferencingHiveAndDeltaTable

@ebyhr ebyhr force-pushed the ebi/delta-databricks-flaky branch from 683f222 to 0100159 Compare November 4, 2022 09:21
@ebyhr
Copy link
Copy Markdown
Member Author

ebyhr commented Nov 4, 2022

Not sure why IntelliJ returned wrong results. Just added the annotation to all of DELTA_LAKE_DATABRICKS regardless of the detailed tests.

@findinpath
Copy link
Copy Markdown
Contributor

You're still missing

  • io.trino.tests.product.deltalake.TestDeltaLakeDatabricksCheckpointsCompatibility#testTrinoCheckpointNullStatisticsForRowType
  • io.trino.tests.product.deltalake.TestDeltaLakeDatabricksCheckpointsCompatibility#testDatabricksCheckpointNullStatisticsForRowType

@ebyhr ebyhr force-pushed the ebi/delta-databricks-flaky branch from 0100159 to 502488e Compare November 4, 2022 09:42
@findinpath findinpath self-requested a review November 4, 2022 10:39
@ebyhr
Copy link
Copy Markdown
Member Author

ebyhr commented Nov 4, 2022

Pushed an empty commit because there was no retrying with "Communication link failure".

@ebyhr
Copy link
Copy Markdown
Member Author

ebyhr commented Nov 7, 2022

https://github.com/trinodb/trino/actions/runs/3407215065/jobs/5666758475 has retrying with "Communication link failure", but TestDeltaLakeDatabricksCheckpointsCompatibility.testDatabricksWriteStatsAsJsonEnabled has NPE. Going to fix the issue.

@ebyhr ebyhr force-pushed the ebi/delta-databricks-flaky branch from b9db479 to 62238b5 Compare November 7, 2022 05:13
@findinpath findinpath self-requested a review November 7, 2022 05:19
@ebyhr ebyhr requested a review from findepi November 7, 2022 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed no-release-notes This pull request does not require release notes entry

Development

Successfully merging this pull request may close these issues.

3 participants