Fix Hive test table name collision#14883
Merged
sopel39 merged 1 commit intotrinodb:masterfrom Nov 3, 2022
Merged
Conversation
In TestHiveTransactionalTable both testAcidUpdateSelectedValues and testAcidUpdateSimple use the root test name test_update_simple, and withTemporaryTable did not add a random suffix, so the the two tests using that root name collided. This PR changes the table name used in the former test, and also changes withTemporaryTable to add a random table name suffix.
sopel39
approved these changes
Nov 3, 2022
gaurav8297
approved these changes
Nov 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In TestHiveTransactionalTable both testAcidUpdateSelectedValues and testAcidUpdateSimple use the root test name test_update_simple, and withTemporaryTable did not add a random suffix, so the the two tests using that root name collided. This PR changes the table name used in the former test, and also changes withTemporaryTable to add a random table name suffix. Fixes #14519.
Description
Non-technical explanation
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: