Add support for DELETE statement in MongoDB#14864
Merged
ebyhr merged 2 commits intotrinodb:masterfrom Nov 14, 2022
Merged
Conversation
ebyhr
force-pushed
the
ebi/mongodb-delete
branch
from
2938e10 to
0eef21d
Compare
Member
|
On a different note, do we have any test with MongoDB's collation ? Will it affect the predicate or delete pushdown ? |
Praveen2112
approved these changes
Nov 4, 2022
Member
Praveen2112
left a comment
Praveen2112
left a comment
There was a problem hiding this comment.
Change looks good to me but I think we need to check it the specifying collation affects the behavior. https://www.mongodb.com/docs/manual/reference/collation/#collation
Member
Author
|
Good catch. Just confirmed the correctness issue happens when collections have collation. I will fix the issue first in #14900. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for DELETE statement in MongoDB
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: