Add Databricks 11.3 test environment to Delta Lake #14848
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package io.trino.tests.product.launcher.env.environment; | ||
|
|
||
| import com.google.inject.Inject; | ||
| import io.trino.tests.product.launcher.docker.DockerFiles; | ||
| import io.trino.tests.product.launcher.env.common.Standard; | ||
| import io.trino.tests.product.launcher.env.common.TestsEnvironment; | ||
|
|
||
| import static java.util.Objects.requireNonNull; | ||
|
|
||
| @TestsEnvironment | ||
| public class EnvSinglenodeDeltaLakeDatabricks113 | ||
| extends AbstractSinglenodeDeltaLakeDatabricks | ||
| { | ||
| @Inject | ||
| public EnvSinglenodeDeltaLakeDatabricks113(Standard standard, DockerFiles dockerFiles) | ||
| { | ||
| super(standard, dockerFiles); | ||
| } | ||
|
|
||
| @Override | ||
| String databricksTestJdbcUrl() | ||
| { | ||
| return requireNonNull(System.getenv("DATABRICKS_113_JDBC_URL"), "Environment DATABRICKS_113_JDBC_URL was not set"); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package io.trino.tests.product.launcher.suite.suites; | ||
|
|
||
| import com.google.common.collect.ImmutableList; | ||
| import io.trino.tests.product.launcher.env.EnvironmentConfig; | ||
| import io.trino.tests.product.launcher.env.environment.EnvSinglenodeDeltaLakeDatabricks113; | ||
| import io.trino.tests.product.launcher.suite.SuiteDeltaLakeDatabricks; | ||
| import io.trino.tests.product.launcher.suite.SuiteTestRun; | ||
|
|
||
| import java.util.List; | ||
|
|
||
| import static io.trino.tests.product.launcher.suite.SuiteTestRun.testOnEnvironment; | ||
|
|
||
| public class SuiteDeltaLakeDatabricks113 | ||
| extends SuiteDeltaLakeDatabricks | ||
| { | ||
| @Override | ||
| public List<SuiteTestRun> getTestRuns(EnvironmentConfig config) | ||
| { | ||
| return ImmutableList.of( | ||
| testOnEnvironment(EnvSinglenodeDeltaLakeDatabricks113.class) | ||
| .withGroups("configured_features", "delta-lake-databricks") | ||
| .withExcludedGroups("delta-lake-exclude-113") | ||
| .withExcludedTests(getExcludedTests()) | ||
| .build()); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this two entries?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's under
excludesection. These two entries are required to ignore hdp3 always and then enable another one when the secret exists in my understanding.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nineinchnick @hashhar please review the ci.yml changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Note it adds quite a lot of time to the total CI runtime:
Do we need to test all LTSes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've brought up EOLing the tests for version 7.3. Maybe it's time, though DB is supporting it through March