Do not create temporary staging path for CREATE TABLE statement

[weijiii]

Description

I am continuing the work in #5802 .
The issue is that both CREATE TABLE and CREATE TABLE AS ... use forNewTable to generate a LocationHandle. In subsequent operations the directory created for CREATE TABLE is never renamed as the target directory because there was no data written to it.
The solution is to not create any temporary staging directory for CREATE TABLE operations. As suggested by the previous discussion I decided to create a new API forNewTableAsSelect in LocationService, and modify the original forNewTable to not create any temporary staging directory as it should.

Non-technical explanation

Currently during CREATE TABLE operation, Trino creates a unnecessary directory that is not used and cleaned up afterwards. This patch will fix this issue.

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

[weijiii]

cc: @phd3

[phd3]

l'd simplify this as below - as we don't care about external location anyway.

Path forNewTable(SemiTransactionalHiveMetastore metastore, ConnectorSession session, String schemaName, String tableName);

[phd3]

nit: if nothing specific being set - better to remove as this is default ?

[phd3]

remove?

[phd3]

nit: inline

[phd3]

nit: split args once above is inlined

[weijiii]

@phd3 I'll address these comments in next revision.

[weijiii]

@phd3 I have made changes according to your comments above. Please take a look when you have time. Thanks!

[weijiii]

IIUC this comment is suggesting to change split the arguments of the method call on line 3011 to separate lines with principalPrivileges inlined.

[phd3]

lgtm, just one comment

[phd3]

I'd actually use a test-local prefix (with a random suffix) - as any reuse of this static variable in future tests can potentially break the assertion

[weijiii]

Makes sense; I'll make the change.

[weijiii]

@phd3 I've addressed this change in the new commit. Please take a look when you have time. Thanks!