Repackage Iceberg runtime exceptions into TrinoException during add/d…#14816
Merged
findepi merged 1 commit intotrinodb:masterfrom Nov 14, 2022
Merged
Repackage Iceberg runtime exceptions into TrinoException during add/d…#14816findepi merged 1 commit intotrinodb:masterfrom
findepi merged 1 commit intotrinodb:masterfrom
Conversation
nastra
force-pushed
the
runtime-ex-to-trino-ex
branch
from
23deca1 to
c872ea7
Compare
Contributor
|
Related comment #13294 (comment) |
findinpath
reviewed
Nov 2, 2022
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java
Outdated
Show resolved
Hide resolved
Contributor
|
Change commit message to |
findepi
reviewed
Nov 3, 2022
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
Outdated
Show resolved
Hide resolved
nastra
force-pushed
the
runtime-ex-to-trino-ex
branch
2 times, most recently
from
59cc066 to
be658cf
Compare
findinpath
approved these changes
Nov 3, 2022
findepi
approved these changes
Nov 4, 2022
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
Outdated
Show resolved
Hide resolved
nastra
force-pushed
the
runtime-ex-to-trino-ex
branch
from
be658cf to
e9ae740
Compare
findepi
approved these changes
Nov 7, 2022
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/BaseIcebergConnectorTest.java
Outdated
Show resolved
Hide resolved
nastra
force-pushed
the
runtime-ex-to-trino-ex
branch
from
e9ae740 to
17a67e1
Compare
Contributor
Author
|
@findepi is this ready to be merged? |
findepi
added
the
no-release-notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #13294 we noticed that during adding/dropping/renaming a column a direct
CommitFailedExceptioncan be thrown from these methods. However, such exceptions should most likely be wrapped in aTrinoException