Fix the default value of partitionedWriterCount and taskConcurrency#14815
Merged
sopel39 merged 2 commits intotrinodb:masterfrom Oct 31, 2022
gaurav8297:gaurav8297/fix_partitioned_writer_count_bug
Merged
Fix the default value of partitionedWriterCount and taskConcurrency#14815sopel39 merged 2 commits intotrinodb:masterfrom gaurav8297:gaurav8297/fix_partitioned_writer_count_bug
sopel39 merged 2 commits intotrinodb:masterfrom
gaurav8297:gaurav8297/fix_partitioned_writer_count_bug
Conversation
sopel39
reviewed
Oct 28, 2022
Member
sopel39
left a comment
sopel39
left a comment
There was a problem hiding this comment.
You should also update config tests
core/trino-main/src/main/java/io/trino/execution/TaskManagerConfig.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/execution/TaskManagerConfig.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/execution/TaskManagerConfig.java
Outdated
Show resolved
Hide resolved
sopel39
approved these changes
Oct 28, 2022
Default value of partitioned task writer count should be above 1, otherwise it can create a plan with a single gather exchange node on the coordinator due to a single available processor. Whereas, on the worker nodes due to more available processors, the default value could be above 1. Therefore, it can cause error due to config mismatch during execution.
Default value of task concurrency should be above 1, otherwise it can create a plan with a single gather exchange node on the coordinator due to a single available processor. Whereas, on the worker nodes due to more available processors, the default value could be above 1. Therefore, it can cause error due to config mismatch during execution.
sopel39
approved these changes
Oct 31, 2022
Member
|
! NO RELEASE NOTES NEEDED ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bug: https://trinodb.slack.com/archives/CGB0QHWSW/p1666885171236349
Non-technical explanation
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: