Skip to content

Refactor JoinMatcher.Builder #14802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sopel39 merged 1 commit into from
Oct 28, 2022
Merged

Refactor JoinMatcher.Builder #14802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions core/trino-main/src/test/java/io/trino/sql/planner/assertions/JoinMatcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ public String toString()

public static class Builder
{
private JoinNode.Type joinType;
private final JoinNode.Type joinType;
private Optional<List<ExpectedValueProvider<JoinNode.EquiJoinClause>>> equiCriteria = Optional.empty();
private Optional<List<PlanMatchPattern.DynamicFilterPattern>> dynamicFilter = Optional.empty();
private Optional<DistributionType> distributionType = Optional.empty();
Expand All @@ -205,11 +205,9 @@ public static class Builder
private PlanMatchPattern right;
private Optional<String> filter = Optional.empty();

public Builder type(JoinNode.Type joinType)
public Builder(JoinNode.Type joinType)
{
this.joinType = joinType;

return this;
}

public Builder equiCriteria(List<ExpectedValueProvider<JoinNode.EquiJoinClause>> expectedEquiCriteria)
Expand Down
2 changes: 1 addition & 1 deletion core/trino-main/src/test/java/io/trino/sql/planner/assertions/PlanMatchPattern.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ public static PlanMatchPattern patternRecognition(Consumer<PatternRecognitionMat

public static PlanMatchPattern join(JoinNode.Type type, Consumer<JoinMatcher.Builder> handler)
{
JoinMatcher.Builder builder = new JoinMatcher.Builder().type(type);
JoinMatcher.Builder builder = new JoinMatcher.Builder(type);
handler.accept(builder);
return builder.build();
}
Expand Down