Fix propagation of noMoreSplits flag to running tasks#14794
Merged
arhimondr merged 2 commits intotrinodb:masterfrom Oct 27, 2022
Merged
Fix propagation of noMoreSplits flag to running tasks#14794arhimondr merged 2 commits intotrinodb:masterfrom
arhimondr merged 2 commits intotrinodb:masterfrom
Conversation
Without the fix, the update with noMoreSplits=true was not called on an open partition in the case when source fragments did not generate any splits. As a result of that, if tasks consuming this partition were scheduled before the partition was sealed they never learned that there will not be any more splits for the partition, and never finished. As a result, the query hung. The common case was that query was completed successfully as usually tasks only started after the partition was already sealed which implied noMoreSplits=true, even if not set explicitly.
arhimondr
approved these changes
Oct 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without the fix, the update with noMoreSplits=true was not called
on an open partition in the case when source fragments did not generate any splits.
As a result of that, if tasks consuming this partition were scheduled
before the partition was sealed they never learned that there will not be any more
splits for the partition, and never finished. As a result, the query hung.
The common case was that query was completed successfully as usually tasks
only started after the partition was already sealed which implied
noMoreSplits=true, even if not set explicitly.
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: