Add register_table procedure support for delta table#14779
Add register_table procedure support for delta table#14779ebyhr merged 1 commit intotrinodb:masterfrom
register_table procedure support for delta table#14779Conversation
05c7aaa to
5df0865
Compare
ce19fb2 to
81456e5
Compare
ae2fba1 to
68cce18
Compare
alexjo2144
left a comment
There was a problem hiding this comment.
Do you have a test that shows the legacy syntax can be re-enabled?
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeConfig.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeConfig.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeSessionProperties.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeConfig.java
Outdated
Show resolved
Hide resolved
...ino-delta-lake/src/main/java/io/trino/plugin/deltalake/procedure/RegisterTableProcedure.java
Outdated
Show resolved
Hide resolved
...ino-delta-lake/src/main/java/io/trino/plugin/deltalake/procedure/RegisterTableProcedure.java
Outdated
Show resolved
Hide resolved
...ino-delta-lake/src/main/java/io/trino/plugin/deltalake/procedure/RegisterTableProcedure.java
Outdated
Show resolved
Hide resolved
...ino-delta-lake/src/main/java/io/trino/plugin/deltalake/procedure/RegisterTableProcedure.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
You could also just create the table using the Hive or Iceberg connectors, if you have one of those catalogs configured for the test
CREATE TABLE hive.schema.table_name ...
There was a problem hiding this comment.
Just to confirm that I understand correctly, We can create a table using Hive or Iceberg connectors to verify the delta test cases where delta logs are missing?
No, Not yet. I will add the test case for this. |
d99b7d9 to
bb666ee
Compare
c9bcd02 to
fb11ca7
Compare
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeConfig.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMetadata.java
Outdated
Show resolved
Hide resolved
...ino-delta-lake/src/main/java/io/trino/plugin/deltalake/procedure/RegisterTableProcedure.java
Outdated
Show resolved
Hide resolved
...ino-delta-lake/src/main/java/io/trino/plugin/deltalake/procedure/RegisterTableProcedure.java
Outdated
Show resolved
Hide resolved
...ino-delta-lake/src/main/java/io/trino/plugin/deltalake/procedure/RegisterTableProcedure.java
Outdated
Show resolved
Hide resolved
...rino-delta-lake/src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
...rino-delta-lake/src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
...ta-lake/src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeRegisterTableProcedureTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeConfig.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeConfig.java
Outdated
Show resolved
Hide resolved
.../test/java/io/trino/plugin/deltalake/BaseDeltaLakeLegacyCreateTableWithExistingLocation.java
Outdated
Show resolved
Hide resolved
.../test/java/io/trino/plugin/deltalake/BaseDeltaLakeLegacyCreateTableWithExistingLocation.java
Outdated
Show resolved
Hide resolved
...plugin/deltalake/TestDeltaLakeLegacyCreateTableWithExistingLocationUsingSessionProperty.java
Outdated
Show resolved
Hide resolved
...-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeSharedHiveMetastoreWithViews.java
Outdated
Show resolved
Hide resolved
...n/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeTableStatistics.java
Outdated
Show resolved
Hide resolved
...rces/docker/presto-product-tests/conf/environment/multinode-minio-data-lake/delta.properties
Outdated
Show resolved
Hide resolved
...presto-product-tests/conf/environment/singlenode-delta-lake-kerberized-hdfs/delta.properties
Outdated
Show resolved
Hide resolved
...rces/docker/presto-product-tests/conf/environment/singlenode-delta-lake-oss/delta.properties
Outdated
Show resolved
Hide resolved
c11fbc7 to
654cc96
Compare
|
rebased and addressed comments. |
654cc96 to
91db0bb
Compare
...rino-delta-lake/src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
...ta-lake/src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeRegisterTableProcedureTest.java
Outdated
Show resolved
Hide resolved
...ta-lake/src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeRegisterTableProcedureTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeDelete.java
Outdated
Show resolved
Hide resolved
...st/java/io/trino/plugin/deltalake/TestDeltaLakeRegisterTableProcedureUsingHiveMetastore.java
Outdated
Show resolved
Hide resolved
.../test/java/io/trino/plugin/deltalake/TestDeltaLakeLegacyCreateTableWithExistingLocation.java
Outdated
Show resolved
Hide resolved
...rino-delta-lake/src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
...rino-delta-lake/src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
8e39889 to
b7aa101
Compare
...rino-delta-lake/src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
...rino-delta-lake/src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
...rino-delta-lake/src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
...ta-lake/src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeRegisterTableProcedureTest.java
Outdated
Show resolved
Hide resolved
...ta-lake/src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeRegisterTableProcedureTest.java
Outdated
Show resolved
Hide resolved
...ta-lake/src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeRegisterTableProcedureTest.java
Outdated
Show resolved
Hide resolved
...st/java/io/trino/plugin/deltalake/TestDeltaLakeRegisterTableProcedureUsingHiveMetastore.java
Outdated
Show resolved
Hide resolved
...o/plugin/deltalake/metastore/glue/TestDeltaLakeRegisterTableProcedureUsingGlueMetastore.java
Outdated
Show resolved
Hide resolved
...o/plugin/deltalake/metastore/glue/TestDeltaLakeRegisterTableProcedureUsingGlueMetastore.java
Show resolved
Hide resolved
b7aa101 to
9f60dad
Compare
...rino-delta-lake/src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
c4ad97c to
55bdd02
Compare
|
rebased and added |
...rino-delta-lake/src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
...rino-delta-lake/src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
...rino-delta-lake/src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
...rino-delta-lake/src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
...rino-delta-lake/src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
...rino-delta-lake/src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
...ta-lake/src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeRegisterTableProcedureTest.java
Outdated
Show resolved
Hide resolved
.../test/java/io/trino/plugin/deltalake/TestDeltaLakeLegacyCreateTableWithExistingLocation.java
Outdated
Show resolved
Hide resolved
...o/plugin/deltalake/metastore/glue/TestDeltaLakeRegisterTableProcedureUsingGlueMetastore.java
Outdated
Show resolved
Hide resolved
...st/java/io/trino/plugin/deltalake/TestDeltaLakeRegisterTableProcedureUsingHiveMetastore.java
Outdated
Show resolved
Hide resolved
...rino-delta-lake/src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
55bdd02 to
ba3308a
Compare
...ta-lake/src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeRegisterTableProcedureTest.java
Outdated
Show resolved
Hide resolved
...ta-lake/src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeRegisterTableProcedureTest.java
Outdated
Show resolved
Hide resolved
...ta-lake/src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeRegisterTableProcedureTest.java
Outdated
Show resolved
Hide resolved
.../test/java/io/trino/plugin/deltalake/TestDeltaLakeLegacyCreateTableWithExistingLocation.java
Outdated
Show resolved
Hide resolved
|
LGTM % some minor test related improvements. |
|
CI hit #15173 |
|
@hangc0276 pls sketch your scenario in a new github issue - your question is not related to this PR. To be taken into account when writing the new issue
Was writing in the newly registered table happening through |
Description
Fixes #13568
delta.system.register_table(shcema_name => 'testdb', table_name => 'table1', table_location => 's3://my-bukcet/a/path/')CREATE TABLEwith(location='***')will not allow to register table using existing location.delta.create-table-with-existing-location.enabledconfig property orcreate_table_with_existing_location_enabledsession property to allow user to register table usingCREATE TABLEstatement (This support will be removed permanently after some release)register_tableprocedure is disabled. Enable it viadelta.allow-register-table-procedureconfig propertyNon-technical explanation
NA
Release notes
( ) This is not user-visible or docs only and no release notes are required.
(X) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: