Don't send Sphinx build script output to dev/null#14773
Merged
martint merged 1 commit intotrinodb:masterfrom Oct 27, 2022
Merged
Don't send Sphinx build script output to dev/null#14773martint merged 1 commit intotrinodb:masterfrom
martint merged 1 commit intotrinodb:masterfrom
Conversation
mosabua
approved these changes
Oct 26, 2022
MiguelWeezardo
approved these changes
Oct 27, 2022
Member
MiguelWeezardo
left a comment
MiguelWeezardo
left a comment
There was a problem hiding this comment.
Not sure if you'd also like to remove -q (quiet flag)
Member
Author
I'm happy with that one, it's honestly an improvement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#13688 added a
> dev/nullto the Sphinx build script, which swallows up the output of trying to build docs. This is pretty counterproductive for anyone working on docs, because if there are any errors or issues when building, you can't see the output of the script to inform you what/where the error is. It looks like one of the other flags added made it much less verbose, anyway, so un-dev-nulling would be extraordinarily helpful.Non-technical explanation
Make docs easier to work on.
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: