Fix error message when creating table in non-existing schema#14769
Merged
findepi merged 1 commit intotrinodb:masterfrom Nov 5, 2022
Merged
Fix error message when creating table in non-existing schema#14769findepi merged 1 commit intotrinodb:masterfrom
findepi merged 1 commit intotrinodb:masterfrom
Conversation
alexjo2144
reviewed
Oct 26, 2022
testing/trino-product-tests/src/main/java/io/trino/tests/product/TestCreateTable.java
Outdated
Show resolved
Hide resolved
alexjo2144
approved these changes
Oct 26, 2022
ebyhr
reviewed
Oct 26, 2022
Member
There was a problem hiding this comment.
I don't think throwing SchemaNotFoundException for all InvalidObjectException is a good idea. For instance, invalid table name throws InvalidObjectException.
Contributor
There was a problem hiding this comment.
Maybe we should evaluate, in case of dealing with an InvalidObjectException whether the schema actually exists and act accordingly.
findepi
added
the
no-release-notes
Member
Author
|
(just rebased) |
findepi
force-pushed
the
findepi/thrift-foobar-schema
branch
from
65d1f14 to
3efee9b
Compare
Before the change, when using Hive with Thrift HMS, an error message would contain schema name, but not the words "Schema not found" (or the like).
findepi
force-pushed
the
findepi/thrift-foobar-schema
branch
from
3efee9b to
8ebfe6a
Compare
ebyhr
approved these changes
Nov 5, 2022
findinpath
approved these changes
Nov 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before the change, when using Hive with Thrift HMS, an error message would contain schema name, but not the words "Schema not found" (or the like).
Fixes #14741