Fix HiveMinioDataLake leak when start fails#14763
Merged
findepi merged 1 commit intotrinodb:masterfrom Oct 27, 2022
Merged
Conversation
`HiveMinioDataLake.start` starts more than one container. If second fails to start, first will be left running. That's why the class has separate `start` method. The caller needs to hold on to an instance before invoking the `start` method, and ensure `close()` is called regardless of `start` success.
findepi
added
test
no-release-notes
skrzypo987
approved these changes
Oct 26, 2022
Member
skrzypo987
left a comment
skrzypo987
left a comment
There was a problem hiding this comment.
I wonder what we can do to prevent that mistake from happening again.
kokosing
approved these changes
Oct 26, 2022
Praveen2112
approved these changes
Oct 26, 2022
Dith3r
approved these changes
Oct 27, 2022
findepi
deleted the
findepi/fix-hiveminiodatalake-leak-when-start-fails-121c7a
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HiveMinioDataLake.startstarts more than one container. If secondfails to start, first will be left running. That's why the class has
separate
startmethod. The caller needs to hold on to an instancebefore invoking the
startmethod, and ensureclose()is calledregardless of
startsuccess.