Skip to content

Invalidate table handle cache when column changed#14762

Merged
kokosing merged 1 commit intotrinodb:masterfrom
ssheikin:ssheikin/61/oss/table_handle_jdbc_client_caching
Oct 27, 2022
Merged

Invalidate table handle cache when column changed#14762
kokosing merged 1 commit intotrinodb:masterfrom
ssheikin:ssheikin/61/oss/table_handle_jdbc_client_caching

Conversation

@ssheikin
Copy link
Copy Markdown
Contributor

@ssheikin ssheikin commented Oct 26, 2022

Table handle contains column handles. When column is changed, data in cache for table handles is stale.
Test TableHandles cache invalidation on columns change.

Description

Non-technical explanation

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@kokosing
Copy link
Copy Markdown
Member

CI is red

@ssheikin ssheikin force-pushed the ssheikin/61/oss/table_handle_jdbc_client_caching branch from bb5ee88 to eda2b10 Compare October 26, 2022 13:40
Table handle contains column handles. When column is changed,
data in cache for table handles is stale.
Test TableHandles cache invalidation on columns change.
@ssheikin ssheikin force-pushed the ssheikin/61/oss/table_handle_jdbc_client_caching branch from eda2b10 to e8bc529 Compare October 26, 2022 13:43
@findepi
Copy link
Copy Markdown
Member

findepi commented Oct 26, 2022

Is this a user-visible change? I.e. do we need any release notes for this?

@ssheikin
Copy link
Copy Markdown
Contributor Author

I've doublechecked and seems caching jdbc client is always enabled and end users mostly not interested in this change.

@findepi
Copy link
Copy Markdown
Member

findepi commented Oct 26, 2022

I've doublechecked and seems caching jdbc client is always enabled

on per-query basis, yes

and end users mostly not interested in this change.

unless this fixes a bug.

@kokosing kokosing merged commit 1d7f530 into trinodb:master Oct 27, 2022
@ssheikin ssheikin deleted the ssheikin/61/oss/table_handle_jdbc_client_caching branch October 27, 2022 10:52
@github-actions github-actions bot added this to the 402 milestone Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants