Implement getRange for date and timestamp#14747
Merged
findepi merged 7 commits intotrinodb:masterfrom Nov 14, 2022
Merged
Conversation
findepi
added
the
no-release-notes
losipiuk
reviewed
Oct 25, 2022
core/trino-spi/src/main/java/io/trino/spi/type/LongTimestampType.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Oct 25, 2022
core/trino-spi/src/main/java/io/trino/spi/type/ShortTimestampType.java
Outdated
Show resolved
Hide resolved
losipiuk
approved these changes
Oct 25, 2022
Member
Author
|
(just rebased) |
findepi
force-pushed
the
findepi/implement-type-getrange-for-timestamp-type-e776c3
branch
2 times, most recently
from
6e38116 to
ca4af6f
Compare
losipiuk
approved these changes
Nov 4, 2022
The source type's max value is not guaranteed to be coercible into the target type. Back out rather than failing.
Member
Author
|
Added a commit fixing |
findepi
force-pushed
the
findepi/implement-type-getrange-for-timestamp-type-e776c3
branch
from
ca4af6f to
da9914e
Compare
Avoid Apache Commons' `StringUtils`.
This emphasizes that all option are covered.
findepi
force-pushed
the
findepi/implement-type-getrange-for-timestamp-type-e776c3
branch
from
da9914e to
6a9ef3f
Compare
findepi
deleted the
findepi/implement-type-getrange-for-timestamp-type-e776c3
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #12797
following #14703