Fix IDE warnings in trino caches#14744
Merged
findepi merged 1 commit intotrinodb:masterfrom Oct 26, 2022
Merged
Conversation
Guava cache classes use `@ElementTypesAreNonnullByDefault` annotation and some IDEs complain about it when subclasses do not do that. Fixing these warnings has no value in itself, as they are ignorable, but helps notice potentially useful warnings, should there be any.
findepi
added
the
no-release-notes
losipiuk
reviewed
Oct 25, 2022
| @Target(TYPE) | ||
| @TypeQualifierDefault({FIELD, METHOD, PARAMETER}) | ||
| @Nonnull | ||
| @interface ElementTypesAreNonnullByDefault {} |
Member
There was a problem hiding this comment.
so IDE just cares about the name of annotation, not the package it comes from?
losipiuk
approved these changes
Oct 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guava cache classes use
@ElementTypesAreNonnullByDefaultannotation and some IDEs complain about it when subclasses do not do that.Fixing these warnings has no value in itself, as they are ignorable, but helps notice potentially useful warnings, should there be any.