Remove unnecessary pattern matching in testShowCreateTable#14724
Merged
findepi merged 2 commits intotrinodb:masterfrom Oct 25, 2022
Conversation
findepi
added
test
no-release-notes
findepi
force-pushed
the
findepi/remove-unnecessary-pattern-matching-in-testshowcreatetable-a08b76
branch
3 times, most recently
from
6ad8cc6 to
102ced2
Compare
Member
|
failures look related @findepi |
This somewhat improves test coverage, since now we also validate the catalog and schema are correctly reported back.
Migrate some usages of `computeActual(...).getOnlyValue()` to `computeScalar()` short-hand.
findepi
force-pushed
the
findepi/remove-unnecessary-pattern-matching-in-testshowcreatetable-a08b76
branch
from
102ced2 to
9276615
Compare
Member
Author
|
hopefully fixed now. not every test wants to run on my laptop though |
findepi
deleted the
findepi/remove-unnecessary-pattern-matching-in-testshowcreatetable-a08b76
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This somewhat improves test coverage, since now we also validate the catalog and schema are correctly reported back.