Skip to content

Rename ForwardingConnection delegate method#14723

Merged
findepi merged 1 commit intotrinodb:masterfrom
findepi:findepi/rename-forwardingconnection-delegate-method-fb89c2
Oct 25, 2022
Merged

Rename ForwardingConnection delegate method#14723
findepi merged 1 commit intotrinodb:masterfrom
findepi:findepi/rename-forwardingconnection-delegate-method-fb89c2

Conversation

@findepi
Copy link
Copy Markdown
Member

@findepi findepi commented Oct 24, 2022

Rename getDelegate() to delegate() to be consistent with all the forwarding classes in Guava.

Rename `getDelegate()` to `delegate()` to be consistent with all the
forwarding classes in Guava.
@findepi findepi added the no-release-notes This pull request does not require release notes entry label Oct 24, 2022
@cla-bot cla-bot bot added the cla-signed label Oct 24, 2022
@findepi
Copy link
Copy Markdown
Member Author

findepi commented Oct 25, 2022

cc @huberty89

@findepi findepi merged commit 4a8fb5a into trinodb:master Oct 25, 2022
@github-actions github-actions bot added this to the 401 milestone Oct 25, 2022
@findepi findepi deleted the findepi/rename-forwardingconnection-delegate-method-fb89c2 branch October 25, 2022 06:43
@kokosing
Copy link
Copy Markdown
Member

Rename getDelegate() to delegate() to be consistent with all the forwarding classes in Guava.

I am not sure if it is a goal to make Trino codebase consistent with Guava. I understand that we are using same design pattern which is a forwarding class, but it does not mean we should not follow their codestyle. Guava likes to skip set and get for their setters and getters, while we keep them. I don't mind removing them, but I would prefer to be consistent in Trino codebase.

No changes are requested. Just wanted to share m2c.

@losipiuk
Copy link
Copy Markdown
Member

Rename getDelegate() to delegate() to be consistent with all the forwarding classes in Guava.

I am not sure if it is a goal to make Trino codebase consistent with Guava. I understand that we are using same design pattern which is a forwarding class, but it does not mean we should not follow their codestyle. Guava likes to skip set and get for their setters and getters, while we keep them. I don't mind removing them, but I would prefer to be consistent in Trino codebase.

No changes are requested. Just wanted to share m2c.

m2c too. In the future we will be kinda forced to change our style to not have get.. in getters as we will be using records more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed no-release-notes This pull request does not require release notes entry

Development

Successfully merging this pull request may close these issues.

4 participants