Skip to content

Don't run testTrinoPreservesReaderAndWriterVersions in Databricks 7.3 #14687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebyhr merged 1 commit into from
Oct 21, 2022
Merged

Don't run testTrinoPreservesReaderAndWriterVersions in Databricks 7.3 #14687

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .../src/main/java/io/trino/tests/product/deltalake/TestDeltaLakeAlterTableCompatibility.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,9 +264,11 @@ public void testTrinoAlterTablePreservesTableMetadata()
}
}

@Test(groups = {DELTA_LAKE_DATABRICKS, DELTA_LAKE_OSS, PROFILE_SPECIFIC_TESTS})
@Test(groups = {DELTA_LAKE_DATABRICKS, DELTA_LAKE_EXCLUDE_73, DELTA_LAKE_OSS, PROFILE_SPECIFIC_TESTS})
Copy link
Copy Markdown
Member

@findepi findepi Oct 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the exclusion?

Copy link
Copy Markdown
Member Author

@ebyhr ebyhr Oct 19, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version 7.3 doesn't support delta.minReaderVersion and delta.minWriterVersion table properties. It causes query failure.

I will take a look if we shouldn't write those properties when existing tables don't have those properties.

io.trino.tempto.query.QueryExecutionException: java.sql.SQLException: [Databricks][DatabricksJDBCDriver](500051) ERROR processing query/statement. Error Code: 0, SQL state: Error running query: org.apache.spark.sql.AnalysisException: Unknown configuration was specified: delta.minWriterVersion;, Query: CREATE TABLE default.test_trino_preserves_versions_vtizu3eknquk (col int) USING DELTA LOCATION 's3://trino-ci-test/databricks-compatibility-test-test_trino_preserves_versions_vtizu3eknquk'TBLPROPERTIES ('delta.minReaderVersion'='1', 'delta.minWriterVersion'='1', 'delta.checkpointInterval' = 1).

Copy link
Copy Markdown
Member

@findepi findepi Oct 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation. Can it be captured as a code comment?

public void testTrinoPreservesReaderAndWriterVersions()
{
// Databricks 7.3 doesn't support 'delta.minReaderVersion' and 'delta.minWriterVersion' table properties
// Writing those properties to protocol entry in COMMENT and ADD COLUMN statements is fine
String tableName = "test_trino_preserves_versions_" + randomTableSuffix();
String tableDirectory = "databricks-compatibility-test-" + tableName;

Expand Down