Don't exclude server modules when checking impacted modules#14632
Don't exclude server modules when checking impacted modules#14632hashhar merged 1 commit intotrinodb:masterfrom
Conversation
|
@hashhar PTAL |
If the server and/or rpm modules are impacted, the list of impacted modules should not be empty, because otherwise it will cause all tests to run.
a59fc42 to
a2ed5cf
Compare
hashhar
left a comment
There was a problem hiding this comment.
Can you remind me what user visible effect we're trying to solve here?
IIRC the issue can be that if you change trino-server or trino-server-rpm then the -pl excluding them causes them to also be excluded from GIB's impacted list. Meaning that the impacted list becomes empty causing unnecessary tests to run?
It'll be good to mention that -pl impacts the GIB impacted list - it's not obvious from the commit message why those two would be related.
|
We usually exclude the server modules because they take a long time to build. But in the validate step they should not be excluded, because:
If the impacted modules list is empty, in the |
Description
If the server and/or rpm modules are impacted, the list of impacted modules should not be empty, because otherwise, it will cause all tests to run.
Non-technical explanation
n/a
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: