Skip to content

Use correct variable for event name in CI#14624

Merged
martint merged 1 commit intotrinodb:masterfrom
nineinchnick:skip-product-tests-in-prs
Oct 13, 2022
Merged

Use correct variable for event name in CI#14624
martint merged 1 commit intotrinodb:masterfrom
nineinchnick:skip-product-tests-in-prs

Conversation

@nineinchnick
Copy link
Copy Markdown
Member

Description

In #14541 I made a typo, so now all product tests are always executed in pull requests. This PR fixes it.

Non-technical explanation

n/a

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

Copy link
Copy Markdown
Member

@findepi findepi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i trust this is a good change. it's looks decent

@nineinchnick
Copy link
Copy Markdown
Member Author

It is consistent with other occurrences of github.event_name in the same file. I have no idea how I did not notice that before :-(

@martint martint merged commit a0c744b into trinodb:master Oct 13, 2022
@martint martint added this to the 400 milestone Oct 13, 2022
@nineinchnick nineinchnick deleted the skip-product-tests-in-prs branch November 2, 2022 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants