Fix JSON serialization of QueryCompletedEvent#14604
Merged
electrum merged 2 commits intotrinodb:masterfrom Oct 13, 2022
Merged
Conversation
martint
approved these changes
Oct 12, 2022
Member
martint
left a comment
martint
left a comment
There was a problem hiding this comment.
Add the following text to the commit message:
Implementations of Count, Timing and Distribution are not in the SPI, and therefore
they are not visible to the json serializer. As a result, they cannot be embedded
in event listener objects. Doing so causes errors when attempting to log
query events.
This reverts commit a102324. Implementations of Count, Timing and Distribution are not in the SPI, and therefore they are not visible to the json serializer. As a result, they cannot be embedded in event listener objects. Doing so causes errors when attempting to log query events.
electrum
force-pushed
the
eventlistener
branch
from
b2695d0 to
4520bed
Compare
Member
|
thanks for adding this explanation:
should there be a test for this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This reverts a regression introduced in #14400
Release notes
(x) Release notes are required, with the following suggested text: