Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -34,12 +34,6 @@ public class HiveMinioDataLake
public static final String MINIO_ACCESS_KEY = Minio.MINIO_ACCESS_KEY;
@Deprecated
public static final String MINIO_SECRET_KEY = Minio.MINIO_SECRET_KEY;
/**
* In S3 this region is implicitly the default one. In Minio, however,
* if we set an empty region, it will accept any.
* So setting it by default to `us-east-1` simulates S3 better
*/
public static final String MINIO_DEFAULT_REGION = "us-east-1";

private final String bucketName;
private final Minio minio;
Expand Down Expand Up @@ -70,7 +64,6 @@ public HiveMinioDataLake(String bucketName, Map<String, String> hiveHadoopFilesT
.withEnvVars(ImmutableMap.<String, String>builder()
.put("MINIO_ACCESS_KEY", MINIO_ACCESS_KEY)
.put("MINIO_SECRET_KEY", MINIO_SECRET_KEY)
.put("MINIO_REGION", MINIO_DEFAULT_REGION)
.buildOrThrow())
.build());

Expand All @@ -81,7 +74,7 @@ public HiveMinioDataLake(String bucketName, Map<String, String> hiveHadoopFilesT
this.hiveHadoop = closer.register(hiveHadoopBuilder.build());
}

public HiveMinioDataLake start()
public void start()
{
checkState(state == State.INITIAL, "Already started: %s", state);
state = State.STARTING;
Expand All @@ -90,8 +83,6 @@ public HiveMinioDataLake start()
minioClient = closer.register(minio.createMinioClient());
minio.createBucket(bucketName);
state = State.STARTED;

return this;
}

public void stop()
Expand Down

This file was deleted.