Limit number of files for a single ExchangeStorageReader#14580
Merged
arhimondr merged 1 commit intotrinodb:masterfrom Oct 12, 2022
Merged
Limit number of files for a single ExchangeStorageReader#14580arhimondr merged 1 commit intotrinodb:masterfrom
arhimondr merged 1 commit intotrinodb:masterfrom
Conversation
ExchangeStorageReader implementations try to load all files concurrently if possible. If the number of files is large (e.g.: a lot of small files) the underlying implementation may not be able to handle that many concurrent fetch requests.
Contributor
Author
|
Fixes #14496 |
linzebing
approved these changes
Oct 11, 2022
losipiuk
approved these changes
Oct 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ExchangeStorageReader implementations try to load all files concurrently if possible. If the number of files is large (e.g.: a lot of small files) the underlying implementation may not be able to handle that many concurrent fetch requests.
Non-technical explanation
Fix occasional "Maximum pending connection acquisitions exceeded" failures in fault tolerant execution.
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(X) Release notes are required, with the following suggested text: