Track active requests in S3FileSystemExchangeStorage#14574
Merged
arhimondr merged 1 commit intotrinodb:masterfrom Oct 13, 2022
Merged
Track active requests in S3FileSystemExchangeStorage#14574arhimondr merged 1 commit intotrinodb:masterfrom
arhimondr merged 1 commit intotrinodb:masterfrom
Conversation
arhimondr
force-pushed
the
instrument-aws-client
branch
from
ce3639b to
ec2b884
Compare
martint
reviewed
Oct 11, 2022
...system/src/main/java/io/trino/plugin/exchange/filesystem/s3/S3FileSystemExchangeStorage.java
Outdated
Show resolved
Hide resolved
arhimondr
force-pushed
the
instrument-aws-client
branch
from
ec2b884 to
7f7aec3
Compare
losipiuk
reviewed
Oct 12, 2022
Member
There was a problem hiding this comment.
where exactly are the separate requests for pages handled?
Contributor
Author
There was a problem hiding this comment.
This is done by passing the reference to the wrapper to the ListObjectsV2Publisher
return new ListObjectsV2Publisher(this, applyPaginatorUserAgent(listObjectsV2Request));
arhimondr
force-pushed
the
instrument-aws-client
branch
from
7f7aec3 to
1119993
Compare
arhimondr
changed the title
Member
|
We no longer need this PR, right? |
Member
Exposing stats via JMX is still nice. I would keep it. |
losipiuk
approved these changes
Oct 12, 2022
linzebing
approved these changes
Oct 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
To help diagnose the issue described in #14496
Non-technical explanation
N/A
Release notes
(X) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: