Skip to content

Report HashBuilderOperator stat for join build-side in EXPLAIN ANALYZE #14572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sopel39 merged 3 commits into from
Oct 25, 2022
Merged

Report HashBuilderOperator stat for join build-side in EXPLAIN ANALYZE #14572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7abdfdc
Adjust comment to provide a better, real example
sopel39 Sep 30, 2022
bcaa9d3
Sum spilled bytes for all operators of a plan node
sopel39 Sep 30, 2022
f0a7401
Report HashBuilderOperator stat for join build-side in EXPLAIN ANALYZE
sopel39 Oct 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions core/trino-main/src/main/java/io/trino/sql/planner/planprinter/PlanNodeStatsSummarizer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,11 +106,17 @@ private static List<PlanNodeStats> getPlanNodeStats(TaskStats taskStats)
planNodeCpuMillis.merge(planNodeId, cpuMillis, Long::sum);

planNodeBlockedMillis.merge(planNodeId, operatorStats.getBlockedWall().toMillis(), Long::sum);
planNodeSpilledDataSize.merge(planNodeId, operatorStats.getSpilledDataSize().toBytes(), Long::sum);

// A pipeline like hash build before join might link to another "internal" pipelines which provide actual input for this plan node
// A plan node like LocalExchange consists of LocalExchangeSource which links to another pipeline containing LocalExchangeSink
if (operatorStats.getPlanNodeId().equals(inputPlanNode) && !pipelineStats.isInputPipeline()) {
continue;
}
// Skip DynamicFilterSourceOperator as input operator as for join build side HashBuilderOperator metrics
Comment thread
sopel39 marked this conversation as resolved.
Outdated
// should be reported
if (operatorStats.getOperatorType().equals("DynamicFilterSourceOperator")) {
continue;
}
if (processedNodes.contains(planNodeId)) {
continue;
}
Expand All @@ -128,7 +134,6 @@ private static List<PlanNodeStats> getPlanNodeStats(TaskStats taskStats)

planNodeInputPositions.merge(planNodeId, operatorStats.getInputPositions(), Long::sum);
planNodeInputBytes.merge(planNodeId, operatorStats.getInputDataSize().toBytes(), Long::sum);
planNodeSpilledDataSize.merge(planNodeId, operatorStats.getSpilledDataSize().toBytes(), Long::sum);
processedNodes.add(planNodeId);
}

Expand Down
7 changes: 0 additions & 7 deletions core/trino-main/src/main/java/io/trino/sql/planner/planprinter/TextRenderer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,13 +247,6 @@ private static Map<String, String> translateOperatorTypes(Set<String> operators)
"HashBuilderOperator", "Right (build) ");
}

if (operators.contains("LookupJoinOperator") && operators.contains("DynamicFilterSourceOperator")) {
Comment thread
sopel39 marked this conversation as resolved.
Outdated
// join plan node
return ImmutableMap.of(
"LookupJoinOperator", "Left (probe) ",
"DynamicFilterSourceOperator", "Right (build) ");
}

return ImmutableMap.of();
}

Expand Down