Improve startup time for tests using HiveMinioDataLake#14561
Closed
findepi wants to merge 1 commit intotrinodb:masterfrom
Closed
Improve startup time for tests using HiveMinioDataLake#14561findepi wants to merge 1 commit intotrinodb:masterfrom
findepi wants to merge 1 commit intotrinodb:masterfrom
Conversation
findepi
added
the
no-release-notes
findepi
requested review from
aczajkowski,
alexjo2144,
ebyhr,
findinpath,
hashhar,
losipiuk and
mdesmet
findepi
force-pushed
the
findepi/improve-startup-time-for-tests-using-hiveminiodatalake-c20056
branch
from
80cb374 to
bd008fe
Compare
aczajkowski
approved these changes
Oct 11, 2022
Member
There was a problem hiding this comment.
NIT: maybe withHdfsAndHiveRuntime(false) or withHdfsAndHiveRuntimeDiasbled()
losipiuk
approved these changes
Oct 11, 2022
findinpath
reviewed
Oct 11, 2022
Contributor
There was a problem hiding this comment.
What about using a dedicated HMS docker image instead of stripping on the fly the services?
https://hub.docker.com/r/starburstdata/hive-metastore may be a viable alternative.
Contributor
There was a problem hiding this comment.
There is also the effort of @nineinchnick to get multi arch support on the existing images. See trinodb/docker-images#143
Not all images include multi arch support but hive3.1-hive has, I guess we can use that image easily for the Iceberg and Delta tests.
Member
Author
There was a problem hiding this comment.
What about using a dedicated HMS docker image instead of stripping on the fly the services?
Good idea, if someone gonna maintain it.
We need one per every hive config we use in these tests, see
io.trino.plugin.hive.containers.HiveHadoop#DEFAULT_IMAGE and io.trino.plugin.hive.containers.HiveHadoop#HIVE3_IMAGE
Contributor
|
findepi
force-pushed
the
findepi/improve-startup-time-for-tests-using-hiveminiodatalake-c20056
branch
4 times, most recently
from
4cae5cb to
4ee3970
Compare
Merged
`HiveMinioDataLake` uses `HiveHadoop` only to have the metastore service. Tests using MinIO don't want to use the HDFS and don't need to wait for it. The startup time is especially severe on Apple M1 chips. The change brings down container startup time from ~43s to ~13s.
findepi
force-pushed
the
findepi/improve-startup-time-for-tests-using-hiveminiodatalake-c20056
branch
from
5feade6 to
676d601
Compare
Member
Author
|
(just rebased to remove commits extracted to #14742) |
findepi
deleted the
findepi/improve-startup-time-for-tests-using-hiveminiodatalake-c20056
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HiveMinioDataLakeusesHiveHadooponly to have the metastore service. Tests using MinIO don't want to use the HDFS and don't need to wait for it.The startup time is especially severe on Apple M1 chips. The change brings down container startup time from ~43s to ~13s.