Convert types to sealed classes where possible#14555
Merged
dain merged 1 commit intotrinodb:masterfrom Oct 11, 2022
Merged
Conversation
martint
reviewed
Oct 10, 2022
core/trino-spi/src/main/java/io/trino/spi/type/LongTimeWithTimeZoneType.java
Outdated
Show resolved
Hide resolved
Convert DecimalType, TimeWithTimeZoneType, and TimestampWithTimeZoneType to sealed classes
dain
force-pushed
the
type-sealed-classes
branch
from
9d7f38e to
a6744ae
Compare
martint
approved these changes
Oct 11, 2022
Member
|
What's the motivation? Does this prevent a plugin from providing specialized types for example? |
Member
These classes were not meant to be extended and it would be dangerous if someone tried that. |
findepi
reviewed
Oct 11, 2022
| public abstract sealed class TimestampWithTimeZoneType | ||
| extends AbstractType | ||
| implements FixedWidthType | ||
| permits LongTimestampWithTimeZoneType, ShortTimestampWithTimeZoneType |
Member
There was a problem hiding this comment.
The @see LongTimestampWithTimeZoneType above became redundant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert DecimalType, TimeWithTimeZoneType, and TimestampWithTimeZoneType to sealed classes
Release notes
(X) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: