Skip to content

Update RPM docs warning about support#14551

Merged
electrum merged 1 commit intotrinodb:masterfrom
sheajamba:rpm-warning-label-docs
Oct 24, 2022
Merged

Update RPM docs warning about support#14551
electrum merged 1 commit intotrinodb:masterfrom
sheajamba:rpm-warning-label-docs

Conversation

@sheajamba
Copy link
Copy Markdown
Member

Description

Updates the wording of the warning for RPM usage.

See: #14524

Non-technical explanation

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Oct 10, 2022
@sheajamba sheajamba requested a review from findepi October 10, 2022 16:18
@github-actions github-actions bot added the docs label Oct 10, 2022
Comment on lines 16 to 17
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

avoid "supported". It has specific meaning to different people. I'd probably suggest saying something like "using the RPM is discouraged in favour of the tarball or Docker containers".

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that.

@mosabua
Copy link
Copy Markdown
Member

mosabua commented Oct 11, 2022

Also @sheajamba .. seems like there is a conflict.. might have to rebase

@sheajamba sheajamba force-pushed the rpm-warning-label-docs branch 2 times, most recently from e659936 to 077b2c3 Compare October 17, 2022 19:39
Copy link
Copy Markdown
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks .. looks good now.

@mosabua
Copy link
Copy Markdown
Member

mosabua commented Oct 18, 2022

@findepi or @hashhar .. can we get this merged please?

@findepi
Copy link
Copy Markdown
Member

findepi commented Oct 19, 2022

i am reluctant to merge since the CI is not green

@mosabua
Copy link
Copy Markdown
Member

mosabua commented Oct 19, 2022

I just checked this out and built the docs locally. It all works. The CI failure is wrong @findepi

@findepi
Copy link
Copy Markdown
Member

findepi commented Oct 19, 2022

If CI is wrong, it may require to be fixed

@mosabua
Copy link
Copy Markdown
Member

mosabua commented Oct 19, 2022

If CI is wrong, it may require to be fixed

Sure .. but this is in io.trino:trino-main and has nothing to do with the docs .. maybe we can just kick off a build again or so?

@colebow is currently looking a disabling flaky tests and such .. maybe this is one of them.

@colebow
Copy link
Copy Markdown
Member

colebow commented Oct 19, 2022

@findepi - I've been looking into CI failures and this is the exact failure that's causing most of the problems on Trino. It looks to me like an issue with Maven downloading a dependency for a plugin, but there is no test failure - it's something wrong with our infra. I haven't been able to repro locally.

@findepi
Copy link
Copy Markdown
Member

findepi commented Oct 20, 2022

Sure .. but this is in io.trino:trino-main and has nothing to do with the docs ..

If this was true, why would we run it as part of the docs build then?

maybe we can just kick off a build again or so?

i think we already tried. it looked deterministic to me, but feel free to add another empty commit here to rerun it.
if it comes green, awesome

@mosabua
Copy link
Copy Markdown
Member

mosabua commented Oct 20, 2022

@sheajamba can you push again so CI runs again, potentially even rebase master into the branch in case something of the original revision you branched off is busted .. maybe it works this time.

@sheajamba sheajamba force-pushed the rpm-warning-label-docs branch from 077b2c3 to aa568c0 Compare October 21, 2022 03:54
@sheajamba
Copy link
Copy Markdown
Member Author

Pushed again and now all have passed.

@mosabua
Copy link
Copy Markdown
Member

mosabua commented Oct 21, 2022

@findepi .. as we suggested .. the failure was a false alarm. Please merge now.

@electrum electrum merged commit 94eee17 into trinodb:master Oct 24, 2022
@github-actions github-actions bot added this to the 401 milestone Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

6 participants