Update RPM docs warning about support#14551
Conversation
There was a problem hiding this comment.
avoid "supported". It has specific meaning to different people. I'd probably suggest saying something like "using the RPM is discouraged in favour of the tarball or Docker containers".
|
Also @sheajamba .. seems like there is a conflict.. might have to rebase |
e659936 to
077b2c3
Compare
|
i am reluctant to merge since the CI is not green |
|
I just checked this out and built the docs locally. It all works. The CI failure is wrong @findepi |
|
If CI is wrong, it may require to be fixed |
Sure .. but this is in io.trino:trino-main and has nothing to do with the docs .. maybe we can just kick off a build again or so? @colebow is currently looking a disabling flaky tests and such .. maybe this is one of them. |
|
@findepi - I've been looking into CI failures and this is the exact failure that's causing most of the problems on Trino. It looks to me like an issue with Maven downloading a dependency for a plugin, but there is no test failure - it's something wrong with our infra. I haven't been able to repro locally. |
If this was true, why would we run it as part of the docs build then?
i think we already tried. it looked deterministic to me, but feel free to add another empty commit here to rerun it. |
|
@sheajamba can you push again so CI runs again, potentially even rebase master into the branch in case something of the original revision you branched off is busted .. maybe it works this time. |
077b2c3 to
aa568c0
Compare
|
Pushed again and now all have passed. |
|
@findepi .. as we suggested .. the failure was a false alarm. Please merge now. |
Description
Updates the wording of the warning for RPM usage.
See: #14524
Non-technical explanation
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: