Support query table function in MongoDB#14535
Merged
ebyhr merged 1 commit intotrinodb:masterfrom Oct 14, 2022
Merged
Conversation
Praveen2112
reviewed
Oct 11, 2022
plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoPageSource.java
Outdated
Show resolved
Hide resolved
plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/TestMongoTableHandle.java
Outdated
Show resolved
Hide resolved
plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/BaseMongoConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoSession.java
Outdated
Show resolved
Hide resolved
plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoSession.java
Outdated
Show resolved
Hide resolved
plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoTableHandle.java
Outdated
Show resolved
Hide resolved
plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoTableHandle.java
Outdated
Show resolved
Hide resolved
plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoTableHandle.java
Outdated
Show resolved
Hide resolved
Praveen2112
reviewed
Oct 11, 2022
plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/ptf/RawQuery.java
Outdated
Show resolved
Hide resolved
plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/ptf/RawQuery.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/mongodb-ptf
branch
from
cde1520 to
d3a555a
Compare
ebyhr
changed the title
raw_query table function in MongoDBquery table function in MongoDB
Member
Author
|
@Praveen2112 Addressed comments. |
Praveen2112
reviewed
Oct 12, 2022
plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoSession.java
Outdated
Show resolved
Hide resolved
plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoTableHandle.java
Outdated
Show resolved
Hide resolved
plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/ptf/Query.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/mongodb-ptf
branch
from
d3a555a to
80d6427
Compare
Member
Author
|
Addressed comments. |
ebyhr
force-pushed
the
ebi/mongodb-ptf
branch
from
80d6427 to
a726f8f
Compare
Praveen2112
approved these changes
Oct 12, 2022
plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoSession.java
Outdated
Show resolved
Hide resolved
plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/ptf/Query.java
Outdated
Show resolved
Hide resolved
plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/BaseMongoConnectorTest.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/mongodb-ptf
branch
from
a726f8f to
c03fc08
Compare
Praveen2112
approved these changes
Oct 12, 2022
Member
Praveen2112
left a comment
Praveen2112
left a comment
There was a problem hiding this comment.
One additional question for my understanding.
plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/MongoSession.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/mongodb-ptf
branch
from
c03fc08 to
8fb7667
Compare
skrzypo987
reviewed
Oct 12, 2022
Member
skrzypo987
left a comment
skrzypo987
left a comment
There was a problem hiding this comment.
Looks good, given my out-of-date knowledge of Mongo.
plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/ptf/Query.java
Outdated
Show resolved
Hide resolved
plugin/trino-mongodb/src/main/java/io/trino/plugin/mongodb/ptf/Query.java
Outdated
Show resolved
Hide resolved
plugin/trino-mongodb/src/test/java/io/trino/plugin/mongodb/BaseMongoConnectorTest.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/mongodb-ptf
branch
from
8fb7667 to
cbd8c2e
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Non-technical explanation
Release notes
(x) Release notes are required, with the following suggested text: