Migrate various tests to new assertions#14528
Merged
martint merged 15 commits intotrinodb:masterfrom Nov 1, 2022
Merged
Conversation
martint
changed the title
martint
force-pushed
the
function-assertions
branch
from
4cc77c0 to
ee4b8d2
Compare
findepi
reviewed
Oct 10, 2022
core/trino-main/src/test/java/io/trino/sql/gen/TestExpressionCompiler.java
Outdated
Show resolved
Hide resolved
martint
force-pushed
the
function-assertions
branch
3 times, most recently
from
6985e23 to
52f6875
Compare
kasiafi
reviewed
Oct 17, 2022
core/trino-main/src/test/java/io/trino/operator/scalar/TestDateTimeFunctions.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/operator/scalar/TestDateTimeFunctions.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/operator/scalar/TestDateTimeFunctions.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/operator/scalar/TestDateTimeFunctions.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/operator/scalar/TestArrayCombinationsFunction.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/sql/gen/TestExpressionCompiler.java
Outdated
Show resolved
Hide resolved
plugin/trino-geospatial/src/test/java/io/trino/plugin/geospatial/TestGeoFunctions.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/sql/gen/TestExpressionCompiler.java
Outdated
Show resolved
Hide resolved
plugin/trino-geospatial/src/test/java/io/trino/plugin/geospatial/TestGeoFunctions.java
Outdated
Show resolved
Hide resolved
It's already disabled, it doesn't actually work (tests fail if enabled), and the whole suite takes under two minutes to run, so it seems unnecessary.
This is needed to test plugins that register custom functions and types
martint
force-pushed
the
function-assertions
branch
from
52f6875 to
6955167
Compare
kasiafi
approved these changes
Oct 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes
(x) This is not user-visible or docs only and no release notes are required.