Test setting S3 region explicitly#14518
Merged
kokosing merged 1 commit intotrinodb:masterfrom Oct 11, 2022
Merged
Conversation
kokosing
approved these changes
Oct 7, 2022
Praveen2112
reviewed
Oct 7, 2022
plugin/trino-hive/src/test/java/io/trino/plugin/hive/containers/HiveMinioDataLake.java
Outdated
Show resolved
Hide resolved
Praveen2112
approved these changes
Oct 7, 2022
Using minio container as a mock of S3. It is, by no means, a proper replacement of the S3 service, but it fails the request if the incorrect region is requested, which proves that the set region is properly sent in the request.
skrzypo987
force-pushed
the
skrzypo/122-s3-region-test
branch
from
bbe36bd to
2285a5b
Compare
Member
Author
|
@kokosing @Praveen2112 I see that there are no more remarks and this is approved. Can we get this merged? |
kokosing
approved these changes
Oct 11, 2022
Member
|
Thanks 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More of an end-to-and test of #14398
Description
Non-technical explanation
Just a new test
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: