Reuse TypeOperators instance from TypeManager in IcebergMetadataFactory #14512
Merged
ebyhr merged 1 commit intotrinodb:masterfrom Oct 7, 2022
Merged
Reuse TypeOperators instance from TypeManager in IcebergMetadataFactory #14512ebyhr merged 1 commit intotrinodb:masterfrom
TypeOperators instance from TypeManager in IcebergMetadataFactory #14512ebyhr merged 1 commit intotrinodb:masterfrom
Conversation
Thus, the connector reuses the same instance between IcebergMetadataFactory and IcebergNodePartitioningProvider.
findinpath
reviewed
Oct 7, 2022
| unsupported.put(columnHandle, domain); | ||
| } | ||
| else if (canEnforceColumnConstraintInSpecs(typeOperators, icebergTable, partitionSpecIds, columnHandle, domain)) { | ||
| else if (canEnforceColumnConstraintInSpecs(typeManager.getTypeOperators(), icebergTable, partitionSpecIds, columnHandle, domain)) { |
Contributor
There was a problem hiding this comment.
Why not inject the TypeOperators instance in both classes through Guice instead of depending on the getter of typeManager ?
Member
Author
There was a problem hiding this comment.
It would require additional bindings. Let me merge as-is.
electrum
approved these changes
Oct 7, 2022
Member
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reuse
TypeOperatorsinstance fromTypeManagerin IcebergMetadataFactoryRelease notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: