Avoid reading Iceberg column stats when they are not needed#14504
Merged
findepi merged 1 commit intotrinodb:masterfrom Oct 13, 2022
Merged
Conversation
alexjo2144
commented
Oct 6, 2022
Member
Author
There was a problem hiding this comment.
@raunaqmorarka can you sanity check for me that isComplete() means that the filter we get from getCurrentPredicate() will not change later in the query?
findepi
approved these changes
Oct 7, 2022
Member
|
@alexjo2144 please check the CI |
Member
Author
|
I forgot that the $partitions table has min/max values in it. Let me see if I can avoid reading the stats if that column isn't read |
Member
|
@alexjo2144 i wouldn't be concerned about |
alexjo2144
force-pushed
the
iceberg/scan-include-column-statistics
branch
from
aac0464 to
9273735
Compare
Member
Author
|
Sounds good, I was hoping that information would be readily available but it'd take some refactoring to SystemTable. I've reverted that change |
findepi
approved these changes
Oct 7, 2022
Member
|
@sopel39 @raunaqmorarka do you want to take a look? |
Member
|
Feel free to continue |
raunaqmorarka
approved these changes
Oct 13, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #14004
The column statistics in Iceberg can be large when there are many files or many columns with statistics collected. Avoid reading these stats if they are not used.
Non-technical explanation
Reduce memory and I/O of Iceberg metadata reads.
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: