Skip to content

Document drop_extended_stats procedure and analyze statement in Iceberg#14490

Merged
ebyhr merged 1 commit intotrinodb:masterfrom
ebyhr:ebi/iceberg-analyze
Oct 7, 2022
Merged

Document drop_extended_stats procedure and analyze statement in Iceberg#14490
ebyhr merged 1 commit intotrinodb:masterfrom
ebyhr:ebi/iceberg-analyze

Conversation

@ebyhr
Copy link
Copy Markdown
Member

@ebyhr ebyhr commented Oct 6, 2022

Description

Document drop_extended_stats procedure and analyze statement in Iceberg

Release notes

(x) This is not user-visible or docs only and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Oct 6, 2022
@ebyhr ebyhr added the no-release-notes This pull request does not require release notes entry label Oct 6, 2022
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from the metadata file.

or

from metadata files.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also.. do we need to explain what extended stats includes. Or link to relevant info?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
only useful on specific columns, like join keys, predicates, grouping keys. You can
only useful on specific columns, like join keys, predicates, or grouping keys. You can

@alexjo2144
Copy link
Copy Markdown
Member

@findepi any thoughts on if we want to document this at all before switching over to the Iceberg Puffin format in 1.1?

@ebyhr ebyhr force-pushed the ebi/iceberg-analyze branch from 07ff759 to e41074b Compare October 6, 2022 22:44
@findepi
Copy link
Copy Markdown
Member

findepi commented Oct 7, 2022

I think we can document this, as long as we make it clear it's an experimental feature, with no backwards compatibility guarantees.
Surely we don't want to paint ourselves into the corner of supporting some non-final implementation, but getting some user feedback would be useful.

@ebyhr ebyhr force-pushed the ebi/iceberg-analyze branch from e41074b to e58a690 Compare October 7, 2022 09:11
@ebyhr ebyhr merged commit d49e1b3 into trinodb:master Oct 7, 2022
@ebyhr ebyhr deleted the ebi/iceberg-analyze branch October 7, 2022 21:40
@github-actions github-actions bot added this to the 400 milestone Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed docs no-release-notes This pull request does not require release notes entry

Development

Successfully merging this pull request may close these issues.

5 participants