Skip to content

Fix support for window aggregates from plugins#14488

Merged
martint merged 1 commit intotrinodb:masterfrom
dain:window-accumulator-class-loader
Oct 6, 2022
Merged

Fix support for window aggregates from plugins#14488
martint merged 1 commit intotrinodb:masterfrom
dain:window-accumulator-class-loader

Conversation

@dain
Copy link
Copy Markdown
Member

@dain dain commented Oct 6, 2022

Change window accumulator compiler to not reference classes from the plugin class loader.

Fixes #14486

Release notes

( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text:

# General
* Fix support for aggregations used in window expressions when the function loaded from a plugin. ({issue}`14486`)

Change window accumulator compiler to not reference classes from the
plugin class loader.

Fixes trinodb#14486
@cla-bot cla-bot bot added the cla-signed label Oct 6, 2022
@findepi
Copy link
Copy Markdown
Member

findepi commented Oct 6, 2022

This is probably 3rd or 4th classloader-related fix for aggregation state classes this year.
I am concerned we lack some end-to-end test, which would exercise plugins in plugin class loaders along with plugin-provided aggregation functions.

@martint martint merged commit 2930362 into trinodb:master Oct 6, 2022
@github-actions github-actions bot added this to the 399 milestone Oct 6, 2022
@dain dain deleted the window-accumulator-class-loader branch October 6, 2022 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

ClassLoader issue using plugin aggregate function in window accumulator: java.lang.NoClassDefFoundError

3 participants