Fix session property documentation for writer scaling#14483
Merged
findepi merged 1 commit intotrinodb:masterfrom Oct 7, 2022
Merged
Fix session property documentation for writer scaling#14483findepi merged 1 commit intotrinodb:masterfrom
findepi merged 1 commit intotrinodb:masterfrom
Conversation
The correct session property name for `task.scale-writers.max-writer-count is task_scale_writers_enabled
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
electrum
approved these changes
Oct 6, 2022
bendemott
changed the title
task.scale-writers.max-writer-count is incorrecttask.scale-writers.enable is incorrect
bendemott
changed the title
task.scale-writers.enable is incorrecttask.scale-writers.enabled is incorrect
Contributor
Author
|
@electrum In my hurry to create this I had the description wrong |
findepi
changed the title
task.scale-writers.enabled is incorrect
findepi
approved these changes
Oct 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The correct session property name for
task.scale-writers.enabledis
task_scale_writers_enabledNon-technical explanation
Simple documentation fix
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: