Add explicit check for modifying data in delta table with CDF enabled

[homar]

Description

Add explicit check for modifying data in delta table with CDF enabled.
Inserts could be allowed as they don't have to do anything special to support CDF but they are blocked by writer version check.

Non-technical explanation

Release notes

(x) This is not user-visible or docs only and no release notes are required.

[ebyhr]

Sent #14508 within the repository.

[findepi]

Is java.lang.Boolean#parseBoolean what Delta is using?

[ebyhr]

This is Delta implementation:

  val CHANGE_DATA_FEED = buildConfig[Boolean](
    "enableChangeDataFeed",
    "false",
    _.toBoolean,
    _ => true,
    "needs to be a boolean.",
    alternateConfs = Seq(CHANGE_DATA_FEED_LEGACY))

  def toBoolean: Boolean = parseBoolean(toString)

  private def parseBoolean(s: String): Boolean =
    if (s != null) s.toLowerCase match {
      case "true" => true
      case "false" => false
      case _ => throw new IllegalArgumentException("For input string: \""+s+"\"")
    }
    else
      throw new IllegalArgumentException("For input string: \"null\"")

[findepi]

So it was blocked before the change as well and the change just introduces an explicit check with an explicit message.

Let's have a different commit and PR title then

[homar]

maven checks were killed because they were super slow, doesn't look like anything actionable

[ebyhr]

Could you rebase on upstream to resolve conflicts?

[colebow]

Could you clarify what the user impact of this is for the release note?

It seems to me like this would always fail (due to that writer version check), but now it's failing with better error messaging?

[ebyhr]

It seems to me like this would always fail (due to that writer version check), but now it's failing with better error messaging?

Correct. There's no need to mention in a release note.