Move Hive plan tests off benchmark module to normal tests#14468
Merged
findepi merged 4 commits intotrinodb:masterfrom Oct 6, 2022
Merged
Move Hive plan tests off benchmark module to normal tests#14468findepi merged 4 commits intotrinodb:masterfrom
findepi merged 4 commits intotrinodb:masterfrom
Conversation
b7ac904 to
e0858c9
Compare
Member
Author
|
For the the jar built from cc @przemekak |
ee4d7a7 to
69e2662
Compare
ebyhr
reviewed
Oct 5, 2022
Member
ebyhr
left a comment
There was a problem hiding this comment.
Could you fix a build failure in trino-benchto-benchmarks? Otherwise, looks good to me.
Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test (default-test) on project trino-benchmark-queries: No tests to run! -> [Help 1]
The `trino-benchto-benchmarks` is for building benchmarks to run with Benchto. The Hive plan tests (`*CostBasedPlanTest`) where put there for convenience, but they belong more to `trino-tests`, and this is where they are being moved. This refactoring is a preparatory step for adding more cost-based plan tests, e.g. with Iceberg connector.
This allows more parallel build.
ff04f16 to
c682121
Compare
raunaqmorarka
approved these changes
Oct 6, 2022
Member
Author
|
i deem the product test failure as unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
trino-benchto-benchmarksis for building benchmarks to run withBenchto. The Hive plan tests (
*CostBasedPlanTest) where put there forconvenience, but they belong more to
trino-tests, and this is wherethey are being moved.
This refactoring is a preparatory step for adding more cost-based plan
tests, e.g. with Iceberg connector.