Skip to content

Move Hive plan tests off benchmark module to normal tests#14468

Merged
findepi merged 4 commits intotrinodb:masterfrom
findepi:findepi/move-hive-plan-tests
Oct 6, 2022
Merged

Move Hive plan tests off benchmark module to normal tests#14468
findepi merged 4 commits intotrinodb:masterfrom
findepi:findepi/move-hive-plan-tests

Conversation

@findepi
Copy link
Copy Markdown
Member

@findepi findepi commented Oct 5, 2022

The trino-benchto-benchmarks is for building benchmarks to run with
Benchto. The Hive plan tests (*CostBasedPlanTest) where put there for
convenience, but they belong more to trino-tests, and this is where
they are being moved.

This refactoring is a preparatory step for adding more cost-based plan
tests, e.g. with Iceberg connector.

@cla-bot cla-bot bot added the cla-signed label Oct 5, 2022
@findepi findepi force-pushed the findepi/move-hive-plan-tests branch 3 times, most recently from b7ac904 to e0858c9 Compare October 5, 2022 11:10
@findepi
Copy link
Copy Markdown
Member Author

findepi commented Oct 5, 2022

For the the jar built from trino-benchto-benchmarks should be identical, as the change is mostly limited to the module's test code & test classpath. The only non-test change is the move of the queries from trino-benchto-benchmarks to trino-benchmark-queries and providing that module as a dependency trino-benchto-benchmarks.
Thus I believe it shouldn't affect anyone running benchmarks.

cc @przemekak

@findepi findepi force-pushed the findepi/move-hive-plan-tests branch from ee4d7a7 to 69e2662 Compare October 5, 2022 11:27
Copy link
Copy Markdown
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix a build failure in trino-benchto-benchmarks? Otherwise, looks good to me.

Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test (default-test) on project trino-benchmark-queries: No tests to run! -> [Help 1]

The `trino-benchto-benchmarks` is for building benchmarks to run with
Benchto. The Hive plan tests (`*CostBasedPlanTest`) where put there for
convenience, but they belong more to `trino-tests`, and this is where
they are being moved.

This refactoring is a preparatory step for adding more cost-based plan
tests, e.g. with Iceberg connector.
This allows more parallel build.
@findepi findepi force-pushed the findepi/move-hive-plan-tests branch from ff04f16 to c682121 Compare October 6, 2022 03:52
@findepi
Copy link
Copy Markdown
Member Author

findepi commented Oct 6, 2022

i deem the product test failure

TestKuduConnectoKerberosSmokeTest > kerberosAuthTicketExpiryTest [groups: profile_specific_tests, kudu]
java.sql.SQLException: Query failed (#20221006_054120_00002_ask4y): Table 'default.nation_7524e8c43bd748cea9f6126f8286eb61' not found

as unrelated

@findepi findepi merged commit 55c36a0 into trinodb:master Oct 6, 2022
@findepi findepi deleted the findepi/move-hive-plan-tests branch October 6, 2022 10:29
@github-actions github-actions bot added this to the 399 milestone Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants