Skip to content

Include dictionaryLookBack size in MultiChannelGroupByHash size #14466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sopel39 merged 1 commit into from
Oct 7, 2022
Merged

Include dictionaryLookBack size in MultiChannelGroupByHash size #14466

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion core/trino-main/src/main/java/io/trino/operator/MultiChannelGroupByHash.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,8 @@ public long getEstimatedSize()
currentPageBuilder.getRetainedSizeInBytes() +
Comment thread
Dith3r marked this conversation as resolved.
Outdated
Comment thread
Dith3r marked this conversation as resolved.
Outdated
sizeOf(groupIdsByHash) +
sizeOf(rawHashByHashPosition) +
preallocatedMemoryInBytes;
preallocatedMemoryInBytes +
(dictionaryLookBack != null ? dictionaryLookBack.getRetainedSizeInBytes() : 0);
}

@Override
Expand Down Expand Up @@ -543,6 +544,7 @@ private int registerGroupId(HashGenerator hashGenerator, Page page, int position

private static final class DictionaryLookBack
{
private static final int INSTANCE_SIZE = toIntExact(ClassLayout.parseClass(DictionaryLookBack.class).instanceSize());
Comment thread
Dith3r marked this conversation as resolved.
Outdated
private final Block dictionary;
private final int[] processed;

Expand Down Expand Up @@ -572,6 +574,13 @@ public void setProcessed(int position, int groupId)
{
processed[position] = groupId;
}

public long getRetainedSizeInBytes()
{
return INSTANCE_SIZE +
sizeOf(processed) +
dictionary.getRetainedSizeInBytes();
}
}

@VisibleForTesting
Expand Down