Rewrite date_trunc in BETWEEN predicate#14451
Closed
findinpath wants to merge 1 commit intotrinodb:masterfrom
Closed
Rewrite date_trunc in BETWEEN predicate#14451findinpath wants to merge 1 commit intotrinodb:masterfrom
date_trunc in BETWEEN predicate#14451findinpath wants to merge 1 commit intotrinodb:masterfrom
Conversation
findinpath
changed the title
date_trunc in BETWEEN predicate
This change allows the engine to infer that, for instance,
given t::timestamp(6)
date_trunc('day', t) BETWEEN TIMESTAMP '2022-01-01 00:00:00' AND TIMESTAMP '2022-01-02 00:00:00'
can be rewritten as
t >= '2022-01-01 00:00:00' t <= '2022-01-02 23:59:59.999999'
The change applies for the temporal types:
- date
- timestamp
- timestamp with time zone
Range predicate BetweenPredicate can be transformed into a `TupleDomain`
and thus help with predicate pushdown.
Range-based `TupleDomain` representation is critical for connectors
which have min/max-based metadata (like Iceberg manifests lists which
play a key role in partition pruning or Iceberg data files), as ranges allow
for intersection tests, something that is hard
to do in a generic manner for `ConnectorExpression`.
findinpath
force-pushed
the
rewrite-date-trunc-in-between-predicate
branch
from
30cd2d6 to
f6d4578
Compare
Member
|
@findinpath is this still in progress/valid? |
Contributor
Author
|
This would be a follow-up after #14648 |
|
This pull request has gone a while without any activity. Tagging for triage help: @mosabua |
|
Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change allows the engine to infer that, for instance,
given t::timestamp(6)
can be rewritten as
The change applies for the temporal types:
datetimestamptimestamp with time zoneRange predicate BetweenPredicate can be transformed into a
TupleDomainand thus help with predicate pushdown.
Range-based
TupleDomainrepresentation is critical for connectorswhich have min/max-based metadata (like Iceberg manifests lists which
play a key role in partition pruning or Iceberg data files), as ranges allow
for intersection tests, something that is hard
to do in a generic manner for
ConnectorExpression.Fixes #14293
This is a spin-off from #14390
Non-technical explanation
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: