Skip to content

Add basic concept and glossary entries#14402

Merged
electrum merged 1 commit intotrinodb:masterfrom
bitsondatadev:glossary-updates-1
Feb 9, 2023
Merged

Add basic concept and glossary entries#14402
electrum merged 1 commit intotrinodb:masterfrom
bitsondatadev:glossary-updates-1

Conversation

@bitsondatadev
Copy link
Copy Markdown
Member

@bitsondatadev bitsondatadev commented Sep 30, 2022

Description

  1. Pull the glossary to the top level of the navigation tree for better visibility.
  2. Add links to sections in concepts page.
  3. Make a cluster concept entry.
  4. Change Server Types header to Architecture.

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

@cla-bot cla-bot bot added the cla-signed label Sep 30, 2022
@github-actions github-actions bot added the docs label Sep 30, 2022
colebow
colebow reviewed Oct 7, 2022
View reviewed changes
@mosabua mosabua requested review from jhlodin and removed request for electrum November 22, 2022 21:23
jhlodin
jhlodin reviewed Nov 22, 2022
View reviewed changes
@bitsondatadev bitsondatadev requested a review from jhlodin January 10, 2023 16:22
colebow
colebow reviewed Jan 10, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@colebow colebow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple quick comments. Otherwise looks good.

docs/src/main/sphinx/glossary.rst Outdated
Comment on lines 7 to 8
Copy link
Copy Markdown
Member

@colebow colebow Jan 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I question the value of these headers. This file just really isn't big enough to warrant them, in my opinion. Alphabetical sorting should be enough.

Copy link
Copy Markdown
Member Author

@bitsondatadev bitsondatadev Jan 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we certainly want to fill these in at some point but for now yeah, it's kind of pointless. I'll keep them there and let's get @electrum's POV on it.

Copy link
Copy Markdown
Member

@nineinchnick nineinchnick Jan 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Trino we don't keep stuff that's not used, so I'd remove them.

Copy link
Copy Markdown
Member Author

@bitsondatadev bitsondatadev Jan 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, well it seems like we're all in agreement here. I'll remove them and keep this conversation open in case @electrum disagrees.

@bitsondatadev bitsondatadev force-pushed the glossary-updates-1 branch 2 times, most recently from cc6b59f to ee2c15f Compare January 10, 2023 17:19
@bitsondatadev bitsondatadev requested a review from colebow January 10, 2023 17:19
@bitsondatadev bitsondatadev removed the request for review from mosabua January 10, 2023 18:14
nineinchnick
nineinchnick approved these changes Jan 10, 2023
View reviewed changes
jhlodin
jhlodin approved these changes Jan 10, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@jhlodin jhlodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % comments

electrum
electrum reviewed Feb 6, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@electrum electrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments. Looks good. Thanks for all the work on this.

@bitsondatadev
Copy link
Copy Markdown
Member Author

bitsondatadev commented Feb 6, 2023

@electrum addressed!

@electrum electrum merged commit d299b11 into trinodb:master Feb 9, 2023
@bitsondatadev
Copy link
Copy Markdown
Member Author

bitsondatadev commented Feb 9, 2023

ty!

@github-actions github-actions bot added this to the 407 milestone Feb 10, 2023
@colebow colebow mentioned this pull request Feb 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@electrum electrum electrum approved these changes

+3 more reviewers

@nineinchnick nineinchnick nineinchnick approved these changes

@jhlodin jhlodin jhlodin approved these changes

@colebow colebow colebow approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed docs

Milestone

407

Development

Successfully merging this pull request may close these issues.

5 participants

@bitsondatadev @electrum @nineinchnick @jhlodin @colebow