Block MemorySplitManager until dynamic filters are delivered#14329
Merged
arhimondr merged 1 commit intotrinodb:masterfrom Sep 29, 2022
Merged
Conversation
Contributor
Author
|
@raunaqmorarka @sopel39 Not sure if that the best way to provide this signal though. Maybe we should think of a better way (take into account consumed / produced dynamic filters). It may require more thoughts. This PR doesn't impact real deployments as usually there's a timeout on how long does a connector wait for dynamic filter. This change is more about making sure the tests are not timing out sporadically. |
losipiuk
reviewed
Sep 28, 2022
Member
losipiuk
left a comment
losipiuk
left a comment
There was a problem hiding this comment.
Works for me - as it solves testing problem.
But I would love to hear what @raunaqmorarka has to say about this.
plugin/trino-memory/src/main/java/io/trino/plugin/memory/MemorySplitManager.java
Outdated
Show resolved
Hide resolved
plugin/trino-memory/src/main/java/io/trino/plugin/memory/MemorySplitManager.java
Outdated
Show resolved
Hide resolved
Otherwise the execution will be blocked at the TableScan level
arhimondr
force-pushed
the
memory-connector-lazy-dynamic-filter
branch
from
6fe0a42 to
467e4ad
Compare
raunaqmorarka
approved these changes
Sep 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Otherwise the execution will be blocked at the TableScan level.
In fault tolerant execution we are considering split availability as a signal that a stage is ready for execution. If splits are enumerated before dynamic filters are available the stage might get blocked indefinitely at TableScan as there might not be enough slots to schedule tasks that collect necessary dynamic filters.
Non-technical explanation
N/A
Release notes
(X) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: