Additional integration test checks#14328
Conversation
|
Will it be not flaky as Can you stress test on CI? |
There was a problem hiding this comment.
there may be some tests which schedule queries in the background and do not necessarily wait for their completion. But we can address that if we see this becoming flaky.
There was a problem hiding this comment.
There was a problem hiding this comment.
When I move it to the previous line it doesn't pass the style check
There was a problem hiding this comment.
Interesting. I have checkstyle set up in IntelliJ and it did not complain. 🤷
There was a problem hiding this comment.
Yeah, my Intellij doesn't complain either (though it is trying to format it with a new line when I try to autoformat). But then the check during the build fails.
testing/trino-testing/src/main/java/io/trino/testing/AbstractTestQueryFramework.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
nit: look unrelated - separate commit?
There was a problem hiding this comment.
If the statement is not closed the query never finishes and doesn't receive a final TaskInfo making the newly introduced check fail
There was a problem hiding this comment.
Still should be a preparatory commit. So adding checks and making project actually pass the checks are separate commits. (fixing makes sense even if we do not have checks).
61a95e9 to
7e950e0
Compare
|
CI: #14368 |
Otherwise the query keeps being active after the tests is finished
Verify all queries report final query info and no tasks are abandoned
In tests further decrease thread pool size to detect potential thread leaks
7e950e0 to
33a9771
Compare
Description
Non-technical explanation
N/A
Release notes
(X) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: