Refactor AWS client metrics implementation

[pettyjamesm]

Description

Refactors AWS client stats for S3 and Glue to to consolidate implementations for core SDK metrics reported by all clients via their RequestMetricCollector. This involves:

• Moving the overlapping subset of TimeStat / CounterStat / AtomicLong fields from TrinoS3FileSystemStats and GlueMetastoreStats into a new AwsSdkClientCoreStats class, and embedding an instance of that class into each with the @Flatten annotation to preserve the same fields.
• Dropping AbstractAwsSdkRequestMetricsCollector and separate subclasses for S3 and Glue in favor of a single shared implementation of AwsSdkClientCoreRequestMetricCollector bound to a given AwsSdkClientCoreStats
• Moving the GlueMetastoreApiStats class to a more general AwsApiCallStats class so that it can be used from other client metrics collectors in the future (none currently implemented in Trino). This is simply a rename and relocation of the class.
• Reporting TimeStat metrics via the new TimeStat#addNanos method which avoids unnecessary time unit conversions and associated floating point precision loss opportunities.

Non-technical explanation

No non-technical explanation for this change should be necessary.

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

[findinpath]

In case of GlueHiveMetastore the stats field is instantiated per instance, because the metastore can be part of different connectors and the stats can be therefore connected per catalog.

trino/plugin/trino-hive/src/main/java/io/trino/plugin/hive/metastore/glue/GlueHiveMetastore.java

Line 169 in fe608f2

private final GlueMetastoreStats stats = new GlueMetastoreStats();

See the outcome of this design choice in the following test:

trino/testing/trino-product-tests/src/main/java/io/trino/tests/product/deltalake/TestDeltaLakeJmx.java

Line 33 in 6310e5e

row("io.trino.plugin.hive.metastore.cache:name=delta,type=cachinghivemetastore"),

[findinpath]

Can we make sure through a product test that the s3 stats are also collected per catalog?

[pettyjamesm]

The per-instance instantiation hasn't changed here, so that will be the same as before. Looking around, I don't see any product tests that use a Glue catalog- which is necessary for the JMX object to be registered for such a test. I would add one if it seemed quick, but I'm not sure about how the product test environments get set up or initialized so I would need some help to get the skeleton set up to add a test here.

[findinpath]

Nevermind. By going through the product tests environments, I noticed that the project doesn't have at the moment a product test environment that can be used for AWS tests.

cc @findepi

[findepi]

#5426

[pettyjamesm]

@findepi / @findinpath - are we ok with the current state of the PR to merge it?

[findinpath]

@pettyjamesm I find the implementation clean. Thank you for putting up the PR.

The only thing I'm not keen of is the seemingly unused method in the AwsApiCallStats for which I would find it hard to reason its purpose without having the context of the comments made in this PR. If the PR gets merged, I wouldn't be surprised if the method disappears in a few weeks/months when somebody else stumbling over it will remove it because it is not used anywhere. Let's remove this method if we don't have a use for it in Trino OSS.

[pettyjamesm]

@findinpath - ok, rebased and pushed a new commit without the extra method. Let me know if you want anything else changed before you're comfortable approving the PR.

[findinpath]

Thank you for the submission and for addressing the comments.

[pettyjamesm]

@findepi - any additional changes necessary before merging this PR?

[findepi]

@alexjo2144 it would be nice if you could help here.

[alexjo2144]

Looks good to me

[alexjo2144]

I don't think the integration tests around JMX are very good. Mind just confirming that you double checked that the stats are still present with the same names?

[pettyjamesm]

I don't think the integration tests around JMX are very good. Mind just confirming that you double checked that the stats are still present with the same names?

I have indeed confirmed the stats are still present with the same names after this refactor.

[pettyjamesm]

@alexjo2144 - anything else you need in order to merge this PR?

[findepi]

thank you @pettyjamesm @alexjo2144

[pettyjamesm]

Thanks!