Conversation
|
I tried to comment out slice serialization in TrinoMainModule and ran a couple of integration tests. It doesn't seem to break anything thus it looks like it was being unused. However it breaks statistics delivery introduced in #14072 |
There was a problem hiding this comment.
Shouldn't this commit also remove the SliceSerialization.* classes?
There was a problem hiding this comment.
Serializing to a UTF string doesn't work for all possible values
just "a String"
"values" -> "codepoints" ?
There was a problem hiding this comment.
Technically it is still serialized into a String (that contains only base64 characters). By values I meant all possible values that a Slice can contain
There was a problem hiding this comment.
I don't know what "UTF string" is.
let's change commit message to sth like
Interpreting as UTF-8 works only for UTF-8 encoded text (and even then not necessarily for all the codepoints),
but a Slice can carry arbitrary bytes.
There was a problem hiding this comment.
Sounds good, let me change the commit message
Interpreting as UTF-8 works only for UTF-8 encoded text (and even then not necessarily for all the codepoints), but a Slice can carry arbitrary bytes.
fe24158 to
efd921f
Compare
Description
Fix Slice to Json serialization for non UTF-8 values
Non-technical explanation
N/A
Release notes
(X) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: